Skip to content

Conversation

@g-plane
Copy link
Contributor

@g-plane g-plane commented Jul 15, 2020

Switched to GitHub Actions.

@g-plane g-plane marked this pull request as ready for review July 16, 2020 04:14
@g-plane
Copy link
Contributor Author

g-plane commented Jul 16, 2020

All tests which ran on GitHub Actions passed. AppVeyor and Travis CI won't succeed because I've deleted their configuration files.

@johnnyreilly
Copy link
Member

Nice work!

Could you undelete the Travis and AppVeyor files please? I'd like to run them side by side for a while before decommissioning (though I'll probably not require them to pass before merging; just interested in looking at the difference)

@g-plane
Copy link
Contributor Author

g-plane commented Jul 16, 2020

I will.

While this question is not related to this PR, are there any plans for migrating the comparison tests to snapshot tests with Jest?

@johnnyreilly
Copy link
Member

are there any plans for migrating the comparison tests to snapshot tests with Jest?

Great question! I've long pondered doing something like that. It looks like webpack uses jest:

https://github.com/webpack/webpack/blob/master/package.json#L122

I guess the problems to solve here are:

If you wanted to take a look, we'd greatly appreciate it! 🌻❤️

@g-plane
Copy link
Contributor Author

g-plane commented Jul 16, 2020

Yes, I know. And, can this PR be merged?

@johnnyreilly johnnyreilly merged commit 74bf400 into TypeStrong:master Jul 16, 2020
@johnnyreilly
Copy link
Member

Nice work! Thank you 😄

Assuming all goes well we'll look to drop AppVeyor soon

@g-plane g-plane deleted the github-actions branch July 17, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants